Hi @nayelyz
A precondition still fails when combined with multiple OR conditions in the same routine.
The precondition behaves like an OR condition more within the routine instead of a precondition.
If the precondition is combined with several AND confitions then it works well as a precondition.
I think this would be worth solving.
Thank you
Hi, I just pinged the team again. Once we get more info, or in case we need your help with something, weâll let you know.
Hi @nayelyz
In case it can help in your report.
I have been looking at the routines in @TAustin Browser+ API in JSON format and I think the error is only in the routines that use a precondition with a Interval condition and multiple conditions with an OR condition.
If the precondition has a condition it is: equal, greater or equal or less than or equal everything works fine.
Here is an example of a routine with a temperature interval precondition combined with two switch conditions = on with AND. Everything works fine Fine.
The precondition is distinguished by the value âtriggerâ: âNeverâ
The trigger conditions have the value âtriggerâ: âAlwaysâ
The IF: { AND: [ ⊠] condition affects the precondition and the two AND conditions.
The precondition has âtriggerâ: âNeverâ and therefore never triggers the execution of the Then part until the two conditions that have âtriggerâ: âAlwaysâ are met.
{
"if": {
"and": [
{
"between": {
"value": {
"device": {
"devices": [
"16fa2ff4-00ca-4b65-b1db-5af142511d65"
],
"component": "main",
"capability": "temperatureMeasurement",
"attribute": "temperature",
"trigger": "Never"
},
"type": "device"
},
"start": {
"decimal": 23,
"type": "decimal"
},
"end": {
"decimal": 26,
"type": "decimal"
},
"changesOnly": false
},
"type": "between"
},
{
"equals": {
"left": {
"device": {
"devices": [
"01caa709-9547-4bd2-b833-1aedeaa57d8d"
],
"component": "main",
"capability": "switch",
"attribute": "switch",
"trigger": "Always"
},
"type": "device"
},
"right": {
"string": "on",
"type": "string"
},
"changesOnly": false
},
"type": "equals"
},
{
"equals": {
"left": {
"device": {
"devices": [
"1d33051b-2218-4f82-a81b-911d6a46c9a9"
],
"component": "main",
"capability": "switch",
"attribute": "switch",
"trigger": "Always"
},
"type": "device"
},
"right": {
"string": "on",
"type": "string"
},
"changesOnly": false
},
"type": "equals"
}
],
"type": "and",
"then": [
{
"notification": {
"push": {
"title": "Termostato, Temperatura: 23~26°C",
"message": "Temperature interval 23° to 26°"
},
"type": "push"
},
"type": "notification"
}
],
"sequence": {
"then": "Parallel",
"else": "Parallel"
}
},
"type": "if"
}
Here is an example of a routine with a temperature Interval precondition, combined with two switch conditions = on with OR. It is fired when any of the OR conditions even if the precondition does not meet:
{
"if": {
"or": [
{
"between": {
"value": {
"device": {
"devices": [
"16fa2ff4-00ca-4b65-b1db-5af142511d65"
],
"component": "main",
"capability": "temperatureMeasurement",
"attribute": "temperature",
"trigger": "Never"
},
"type": "device"
},
"start": {
"decimal": 23,
"type": "decimal"
},
"end": {
"decimal": 26,
"type": "decimal"
},
"changesOnly": false
},
"type": "between"
},
{
"equals": {
"left": {
"device": {
"devices": [
"01caa709-9547-4bd2-b833-1aedeaa57d8d"
],
"component": "main",
"capability": "switch",
"attribute": "switch",
"trigger": "Always"
},
"type": "device"
},
"right": {
"string": "on",
"type": "string"
},
"changesOnly": false
},
"type": "equals"
},
{
"equals": {
"left": {
"device": {
"devices": [
"1d33051b-2218-4f82-a81b-911d6a46c9a9"
],
"component": "main",
"capability": "switch",
"attribute": "switch",
"trigger": "Always"
},
"type": "device"
},
"right": {
"string": "on",
"type": "string"
},
"changesOnly": false
},
"type": "equals"
}
],
"type": "or",
"then": [
{
"notification": {
"push": {
"title": "Termostato, Temperatura: 23~26°C",
"message": "Temperature interval 23° to 26°"
},
"type": "push"
},
"type": "notification"
}
],
"sequence": {
"then": "Parallel",
"else": "Parallel"
}
},
"type": "if"
}
Here is an example of a routine with precondition with temperature <= at 18ÂșC, combined with two switch conditions = on with OR. It is triggered only when any of the OR conditions and the precondition of temperature <= 18ÂșC are fulfilled:
{
"if": {
"and": [
{
"lessThanOrEquals": {
"left": {
"device": {
"devices": [
"16fa2ff4-00ca-4b65-b1db-5af142511d65"
],
"component": "main",
"capability": "temperatureMeasurement",
"attribute": "temperature",
"trigger": "Never"
},
"type": "device"
},
"right": {
"decimal": 18,
"type": "decimal"
},
"changesOnly": false
},
"type": "lessThanOrEquals"
},
{
"or": [
{
"equals": {
"left": {
"device": {
"devices": [
"01caa709-9547-4bd2-b833-1aedeaa57d8d"
],
"component": "main",
"capability": "switch",
"attribute": "switch",
"trigger": "Always"
},
"type": "device"
},
"right": {
"string": "on",
"type": "string"
},
"changesOnly": false
},
"type": "equals"
},
{
"equals": {
"left": {
"device": {
"devices": [
"1d33051b-2218-4f82-a81b-911d6a46c9a9"
],
"component": "main",
"capability": "switch",
"attribute": "switch",
"trigger": "Always"
},
"type": "device"
},
"right": {
"string": "on",
"type": "string"
},
"changesOnly": false
},
"type": "equals"
}
],
"type": "or"
}
],
"type": "and",
"then": [
{
"notification": {
"push": {
"title": "Termostato, Temperatura: entre 18°C y 22°c",
"message": "Temperature interval 18° to 22°"
},
"type": "push"
},
"type": "notification"
}
],
"sequence": {
"then": "Parallel",
"else": "Parallel"
}
},
"type": "if"
}
So this is how it should be done also for preconditions with intervals of values and combined with other OR conditions to works fine.
Hi @nayelyz
Please, could you ask again tomorrow, Monday, about this error in the construction of routines that have an interval of values as a precondition and two or more OR conditions?
It is clear that the construction of the JSON has an error by putting the entire If part inside an OR condition.
This only happens when using a range of values as a precondition, if you use another condition the JSON is built and works fine.
Iâm on it, Iâll let you know the updates as soon as the team shares them with me
This is expected behavior, both items in the OR section act as triggers, however, the routine will only process fully if the precondition is met which is checked during execution
Following up, hereâs the feedback from the team
This is not how it works. The precondition will not act as some sort of blocker to a device triggering the routine, however, it will prevent the routine from running as itâs checked (This means it wonât execute the âthenâ section).
If itâs triggering in your case, the team needs to make a further analysis of that specific routine, for that, they need the following:
Thank you for your effort @nayelyz
Please tell them to be a little more serious, weâre not that stupid and we donât like to be treated as such.
Have they bothered to test the routine to see what is triggered even if the precondition is not met?
If they had tried it, they wouldnât say such nonsense!
I donât know why we bothered to report anything, itâs a pity!
If thatâs how smartthings say
the routine has to work, leave it like that!!!
I donât use it at all, itâs other users who complained. So whoever needs it, open a report.
I donât use âLikesâ, but I totally agree with @Mariano_Colmenarejo there. Heâs discovered a problem, isolated the conditions under which it occurs, diagnosed what the problem actually is, and basically handed it over gift-wrapped. And for his trouble he is basically being told they arenât interested because he didnât tie a bow on it.
The team shared new comments about this, they did make tests with a similar configuration to yours:
We understand your frustration and we can create a report for the team that handles the app.
I really donât think there is any room for interpretation. If we add a precondition we do it because we expect it to achieve something, not for decoration.
If a Routine that allows a precondition that canât possibly do anything is working as designed then I suggest the design sucks.
Yes, Iâve been saying for years how nice it would be to be able to use the public API for everything.
Wow! This is such a weird thread, given all the inconsistencies in edge development and lack of design documentation, suddenly everyone is getting excited!!!
So strangeâŠ
Thanks to @nayelyz who does a great job in difficult circumstances
Hi @nayelyz
In the previous posts, I think itâs quite clear that routines with a different precondition than an interval check work perfectly and the json created is understandable and perfectly represents the operation of the routine created in the app by user
For the intervals in a precondition they just have to implement the same structure in the created json:
I put back the json, from @TAustin API Browser+ menu Automations, Routines, Details, of a routine with precondition <= 18° and two OR conditions that works perfectly
{
"if": {
"and": [
{
"lessThanOrEquals": {
"left": {
"device": {
"devices": [
"16fa2ff4-00ca-4b65-b1db-5af142511d65"
],
"component": "main",
"capability": "temperatureMeasurement",
"attribute": "temperature",
"trigger": "Never"
},
"type": "device"
},
"right": {
"decimal": 18,
"type": "decimal"
},
"changesOnly": false
},
"type": "lessThanOrEquals"
},
{
"or": [
{
"equals": {
"left": {
"device": {
"devices": [
"01caa709-9547-4bd2-b833-1aedeaa57d8d"
],
"component": "main",
"capability": "switch",
"attribute": "switch",
"trigger": "Always"
},
"type": "device"
},
"right": {
"string": "on",
"type": "string"
},
"changesOnly": false
},
"type": "equals"
},
{
"equals": {
"left": {
"device": {
"devices": [
"1d33051b-2218-4f82-a81b-911d6a46c9a9"
],
"component": "main",
"capability": "switch",
"attribute": "switch",
"trigger": "Always"
},
"type": "device"
},
"right": {
"string": "on",
"type": "string"
},
"changesOnly": false
},
"type": "equals"
}
],
"type": "or"
}
],
"type": "and",
"then": [
{
"notification": {
"push": {
"title": "Termostato, Temperatura: entre 18°C y 22°c",
"message": "Temperature interval 18° to 22°"
},
"type": "push"
},
"type": "notification"
}
],
"sequence": {
"then": "Parallel",
"else": "Parallel"
}
},
"type": "if"
}
Thanks again
I see that Nayely says to contact you.
Do you know if there is anything new on this topic?
It is still impossible to make routines with preconditions that have an interval and others OR conditions.
Simple OR conditions behave, without precondition
Thank you
Hi @Mariano_Colmenarejo yes, @nayelyz will be off for a while.
Let me catch up with this case and check for updates, so please give me some time to do it.
Hola @nayelyz, @AlejandroPadilla
This issue still does not work and prevents doing certain types of routines with intervals as a precondition.
Now that my.smartthings.com advanced users shows the routines how they are actually executed, I am going to explain it again by comparing how the routines look in the APP and how they look in my.smartthings.com, advanced users, what is going on to execute.
- This is a routine that works well. It has a precondition that compares a temperature if it is greater than or equal to 25ÂșC and two others OR conditions:
View in App:
View on my.smartthings.com
- This is a malfunctioning routine. It has a precondition that compares a temperature interval 25ÂșC to 27ÂșC and two OR conditions:
View in App:
View on my.smartthings.com
It is clear that the conversion that the Rules engine makes from routines to executable code is incorrect when uses intervals conditions
The precondition disappears and behaves like three simple OR conditions
Thanks
Hi, @Mariano_Colmenarejo.
I added this information to the report, it is very useful, thank you for taking the time to collect it.
Weâll ping the team again to see if they have any feedback about this and let you know.
Hi, @Mariano_Colmenarejo
Just following up, the engineering team found the bug in the Android app, in iOS, there are no issues with range preconditions + OR conditions. So, once the new version of the app gets released (there is no ETA available yet), youâll have to re-create the routine so it gets translated correctly.
